NW | ITP-May-25 | Geraldine Edwards | Module-Data-Groups | Sprint-3 | Quote Generator App #586
Conversation
…on page load, then generate a new random quote when button is clicked
Geraldine-Edwards
added
the
Needs Review
|
Hi @ednut, thank you for reviewing my PR. :) Can you kindly change the label to "complete" if you are satisfied with my code please? (I am happy to have any feedback too, if you feel there are any tweaks I need to make?) Thanks again! |
CameronDowner
added
Complete
|
Hi @ednut - I'm not sure you're signed up as a volunteer at CodeYourFuture at the moment - if you are, can you drop me a DM on Slack? (I'm Daniel Wagner-Hall) to update our records and get you set up? Thank you! |
| @@ -491,3 +517,4 @@ const quotes = [ | |||
| ]; | |||
|
|
|||
| // call pickFromArray with the quotes array to check you get a random quote | |||
| const randomQuote = pickFromArray(quotes); | |||
There was a problem hiding this comment.
What does this variable do, and how is it used? What would break if you removed it?
| document.querySelector("#quote").innerText = randomQuote.quote; | ||
| document.querySelector("#author").innerText = randomQuote.author; |
There was a problem hiding this comment.
This "set both elements to show the quote details" behaviour is repeated twice in your app - if we needed to change it in the future, we'd need to change both locations. Can you think of a way to avoid this?
Learners, PR Template
Self checklist
Changelist
Add JS functionality and styling to Quote Generator App.
Questions
Ask any questions you have for your reviewer.